From: Georges Basile Stavracas Neto Date: Fri, 27 Jul 2018 16:15:16 +0000 (-0300) Subject: boxPointer: Add compatibility API X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~897^2~1^2~88 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=f460f2748d3b1abccce75e32eaaad1a1b9dbf458;p=gnome-shell.git boxPointer: Add compatibility API Because we're late in the cycle, and don't know how many extensions actually rely on this API, this commit adds back the BoxPointer.show() and .hide() functions, with warning messages to notify consumers that this is going to be removed. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/153 --- diff --git a/js/ui/boxpointer.js b/js/ui/boxpointer.js index acb1487b6..f9394e3a7 100644 --- a/js/ui/boxpointer.js +++ b/js/ui/boxpointer.js @@ -80,6 +80,36 @@ var BoxPointer = new Lang.Class({ } }, + // BoxPointer.show() and BoxPointer.hide() are here for only compatibility + // purposes, and will be removed in 3.32. + show(animate, onComplete) { + if (animate !== undefined) { + try { + throw new Error('BoxPointer.show() has been moved to BoxPointer.open(), this code will break in the future.'); + } catch(e) { + logError(e); + this.open(animate, onComplete); + return; + } + } + + this.visible = true; + }, + + hide(animate, onComplete) { + if (animate !== undefined) { + try { + throw new Error('BoxPointer.hide() has been moved to BoxPointer.close(), this code will break in the future.'); + } catch(e) { + logError(e); + this.close(animate, onComplete); + return; + } + } + + this.visible = false; + }, + open(animate, onComplete) { let themeNode = this.actor.get_theme_node(); let rise = themeNode.get_length('-arrow-rise');